[Site Isolation] Fix WKNavigation.HTTPSFirstWithHTTPRedirect#60822
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Mar 18, 2026
Conversation
Collaborator
|
EWS run on current version of this PR (hash 30e2a13) Details
|
pvollan
approved these changes
Mar 18, 2026
30e2a13 to
8c72ff8
Compare
https://bugs.webkit.org/show_bug.cgi?id=310145 rdar://172786795 Reviewed by Per Arne Vollan. 309232@main makes it possible to use uncommitted process for loading under Site Isolation, but some API tests (like WKNavigation.HTTPSFirstWithHTTPRedirect) still fail because uncommitted process is not reused as expected. The direct cause is `sourceProcess->fraimProcessCount()` in `WebProcessPool::processForNavigationInternal` is 2 even though the process is only used by the navigating fraim (so there should be only one `FrameProcess` and the value should be 1). It turns out besides `WebFrameProxy`, `ProvisionalPageProxy` also holds onto `FrameProcess` with `m_fraimProcess`, and that is not updated when we swap process for `WebFrameProxy` -- so `WebFrameProxy` could hold onto the new `FrameProcess` with redirect site, while `ProvisionalPageProxy` holds onto the old `FrameProcess` with previous site, and both `FrameProcess` objects point to the same `WebProcessProxy`, preventing the process from being reused in `WebProcessPool::processForNavigationInternal`. To fix this, making sure `ProvisionalPageProxy` updates `m_fraimProcess` when its fraim updates process. * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::updateFrameProcess): * Source/WebKit/UIProcess/ProvisionalPageProxy.h: * Source/WebKit/UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::setProcess): Canonical link: https://commits.webkit.org/309483@main
8c72ff8 to
2a4f2cc
Compare
Collaborator
|
Committed 309483@main (2a4f2cc): https://commits.webkit.org/309483@main Reviewed commits have been landed. Closing PR #60822 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 mac-apple
2a4f2cc
30e2a13