pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

URL: http://github.com/WebKit/WebKit/pull/60826

assets/global-68dd150ce6c8e711.css" /> [AutoFill Debugging] Skip invalid URLs when extracting links and images by whsieh · Pull Request #60826 · WebKit/WebKit · GitHub
Skip to content

[AutoFill Debugging] Skip invalid URLs when extracting links and images#60826

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
whsieh:eng/310150
Mar 18, 2026
Merged

[AutoFill Debugging] Skip invalid URLs when extracting links and images#60826
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
whsieh:eng/310150

Conversation

@whsieh
Copy link
Member

@whsieh whsieh commented Mar 18, 2026 •
edited by webkit-early-warning-system
Loading

f86e3db

[AutoFill Debugging] Skip invalid URLs when extracting links and images
https://bugs.webkit.org/show_bug.cgi?id=310150
rdar://172706501

Reviewed by Abrar Rahman Protyasha.

Avoid including invalid URLs in text extraction output.

Test: TextExtractionTests.InvalidURLsAreSkipped

* Source/WebKit/Shared/TextExtractionToStringConversion.cpp:
(WebKit::TextExtractionAggregator::stringForURL):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/TextExtractionTests.mm:
(TestWebKitAPI::InvalidURLsAreSkipped)):

Canonical link: https://commits.webkit.org/309452@main

1dc955f

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@whsieh whsieh self-assigned this Mar 18, 2026
@whsieh whsieh added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Mar 18, 2026
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 18, 2026 •
edited
Loading

EWS run on current version of this PR (hash 1dc955f)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win ⏳ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2   🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@whsieh
Copy link
Member Author

whsieh commented Mar 18, 2026

Thanks for the review!

@whsieh whsieh added the merge-queue Applied to send a pull request to merge-queue label Mar 18, 2026
@whsieh
[AutoFill Debugging] Skip invalid URLs when extracting links and images
f86e3db 
https://bugs.webkit.org/show_bug.cgi?id=310150
rdar://172706501

Reviewed by Abrar Rahman Protyasha.

Avoid including invalid URLs in text extraction output.

Test: TextExtractionTests.InvalidURLsAreSkipped

* Source/WebKit/Shared/TextExtractionToStringConversion.cpp:
(WebKit::TextExtractionAggregator::stringForURL):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/TextExtractionTests.mm:
(TestWebKitAPI::InvalidURLsAreSkipped)):

Canonical link: https://commits.webkit.org/309452@main
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Mar 18, 2026

Committed 309452@main (f86e3db): https://commits.webkit.org/309452@main

Reviewed commits have been landed. Closing PR #60826 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f86e3db into WebKit:main Mar 18, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aprotyas aprotyas aprotyas approved these changes

@pxlcoder pxlcoder Awaiting requested review from pxlcoder

@hortont424 hortont424 Awaiting requested review from hortont424

@pascoej pascoej Awaiting requested review from pascoej

@rr-codes rr-codes Awaiting requested review from rr-codes

@megangardner megangardner Awaiting requested review from megangardner

@lilyspiniolas lilyspiniolas Awaiting requested review from lilyspiniolas

Assignees

@whsieh whsieh

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@whsieh @webkit-early-warning-system @webkit-commit-queue @aprotyas
pFad - Phonifier reborn

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.




Check this box to remove all script contents from the fetched content.



Check this box to remove all images from the fetched content.


Check this box to remove all CSS styles from the fetched content.


Check this box to keep images inefficiently compressed and original size.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy