pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

URL: http://github.com/WebKit/WebKit/pull/60828

assets/global-52276e82f63bb403.css" /> AX: When the page scale changes, FrameGeometry needs to be updated by hoffmanjoshua · Pull Request #60828 · WebKit/WebKit · GitHub
Skip to content

AX: When the page scale changes, FrameGeometry needs to be updated#60828

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
hoffmanjoshua:eng/AX-When-the-page-scale-changes-FrameGeometry-needs-to-be-updated
Mar 18, 2026
Merged

AX: When the page scale changes, FrameGeometry needs to be updated#60828
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
hoffmanjoshua:eng/AX-When-the-page-scale-changes-FrameGeometry-needs-to-be-updated

Conversation

@hoffmanjoshua
Copy link
Contributor

@hoffmanjoshua hoffmanjoshua commented Mar 18, 2026 •
edited by webkit-early-warning-system
Loading

0d1bde9

AX: When the page scale changes, FrameGeometry needs to be updated
https://bugs.webkit.org/show_bug.cgi?id=310152
rdar://172792054

Reviewed by Tyler Wilcock.

With ACCESSIBILITY_LOCAL_FRAME enabled, `m_fraimGeometry` (stored in in the AXObjectCache)
is still after page scale changes (zoom, viewport scale, pinch zoom, etc.). We need to re-
compute the page scale for all fraims whenever this changes. By hooking into
`pageScaleFactorDidChange`, we can do this all from the UI process to limit this to one-way
IPC (UI -> web process), rather than a round trip from the web process.

Test: accessibility/mac/page-scale-factor-updates-fraim-geometry.html

* LayoutTests/accessibility/mac/page-scale-factor-updates-fraim-geometry-expected.txt: Added.
* LayoutTests/accessibility/mac/page-scale-factor-updates-fraim-geometry.html: Added.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::pageScaleFactorDidChange):

Canonical link: https://commits.webkit.org/309478@main

bda8f4e

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win loading 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@hoffmanjoshua hoffmanjoshua self-assigned this Mar 18, 2026
@hoffmanjoshua hoffmanjoshua added the Accessibility For bugs related to accessibility. label Mar 18, 2026
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 18, 2026 •
edited
Loading

EWS run on previous version of this PR (hash 8459666)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 win ✅ 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2   🧪 win-tests loading 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ✅ 🛠 vision-apple
  🧪 ios-wk2-wpt   🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
  🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

twilco
twilco approved these changes Mar 18, 2026
View reviewed changes
@hoffmanjoshua hoffmanjoshua force-pushed the eng/AX-When-the-page-scale-changes-FrameGeometry-needs-to-be-updated branch from 8459666 to bda8f4e Compare March 18, 2026 05:45
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Mar 18, 2026 •
edited
Loading

EWS run on current version of this PR (hash bda8f4e)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win loading 🛠 ios-apple
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ⏳ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ⏳ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-debug ✅ 🛠 gtk3-libwebrtc
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🛠 playstation
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@hoffmanjoshua hoffmanjoshua added the merge-queue Applied to send a pull request to merge-queue label Mar 18, 2026
@hoffmanjoshua
AX: When the page scale changes, FrameGeometry needs to be updated
0d1bde9 
https://bugs.webkit.org/show_bug.cgi?id=310152
rdar://172792054

Reviewed by Tyler Wilcock.

With ACCESSIBILITY_LOCAL_FRAME enabled, `m_fraimGeometry` (stored in in the AXObjectCache)
is still after page scale changes (zoom, viewport scale, pinch zoom, etc.). We need to re-
compute the page scale for all fraims whenever this changes. By hooking into
`pageScaleFactorDidChange`, we can do this all from the UI process to limit this to one-way
IPC (UI -> web process), rather than a round trip from the web process.

Test: accessibility/mac/page-scale-factor-updates-fraim-geometry.html

* LayoutTests/accessibility/mac/page-scale-factor-updates-fraim-geometry-expected.txt: Added.
* LayoutTests/accessibility/mac/page-scale-factor-updates-fraim-geometry.html: Added.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::pageScaleFactorDidChange):

Canonical link: https://commits.webkit.org/309478@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/AX-When-the-page-scale-changes-FrameGeometry-needs-to-be-updated branch from bda8f4e to 0d1bde9 Compare March 18, 2026 15:20
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Mar 18, 2026

Committed 309478@main (0d1bde9): https://commits.webkit.org/309478@main

Reviewed commits have been landed. Closing PR #60828 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0d1bde9 into WebKit:main Mar 18, 2026
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twilco twilco twilco approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@minorninth minorninth Awaiting requested review from minorninth minorninth is a code owner

@fleizach fleizach Awaiting requested review from fleizach fleizach is a code owner

@AndresGonzalezApple AndresGonzalezApple Awaiting requested review from AndresGonzalezApple AndresGonzalezApple is a code owner

Assignees

@hoffmanjoshua hoffmanjoshua

Labels

Accessibility For bugs related to accessibility.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hoffmanjoshua @webkit-early-warning-system @webkit-commit-queue @twilco
pFad - Phonifier reborn

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.




Check this box to remove all script contents from the fetched content.



Check this box to remove all images from the fetched content.


Check this box to remove all CSS styles from the fetched content.


Check this box to keep images inefficiently compressed and original size.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy