pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

URL: http://github.com/WebReflection/hyperHTML/commit/e27584ca849461f1a33674b852471d0a2d635283

in="anonymous" media="all" rel="stylesheet" href="https://github.githubassets.com/assets/global-9c8f61f9f58ad7b2.css" /> fixed all attributes issues · WebReflection/hyperHTML@e27584c · GitHub
Skip to content

Commit e27584c

Browse files
WebReflectionWebReflection
committed
fixed all attributes issues
1 parent bef0079 commit e27584c

10 files changed

Lines changed: 16 additions & 16 deletions

File tree

‎cjs/objects/Updates.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ function Cache() {}
2020
Cache.prototype = Object.create(null);
2121

2222
const asHTML = html => ({html});
23+
const attributeChangedCallback = () => {};
2324

2425
const create = (root, paths) => {
2526
const updates = [];
@@ -253,9 +254,8 @@ const setAttribute = (node, name) => {
253254
}
254255
};
255256
} else {
256-
let noOwner = false;
257-
const attribute = node.ownerDocument.createAttributeNode(name);
258-
node.setAttributeNode(attribute);
257+
let noOwner = true;
258+
const attribute = node.ownerDocument.createAttribute(name);
259259
return newValue => {
260260
if (oldValue !== newValue) {
261261
oldValue = newValue;

‎coverage/lcov-report/index.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ <h1>
7777
</div><!-- /wrapper -->
7878
<div class='footer quiet pad2 space-top1 center small'>
7979
Code coverage
80-
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Thu Nov 09 2017 10:29:51 GMT-0300 (-03)
80+
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Thu Nov 09 2017 10:35:34 GMT-0300 (-03)
8181
</div>
8282
</div>
8383
<script src="prettify.js"></script>

‎coverage/lcov-report/shared/constants.js.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ <h1>
157157
</div><!-- /wrapper -->
158158
<div class='footer quiet pad2 space-top1 center small'>
159159
Code coverage
160-
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Thu Nov 09 2017 10:29:51 GMT-0300 (-03)
160+
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Thu Nov 09 2017 10:35:34 GMT-0300 (-03)
161161
</div>
162162
</div>
163163
<script src="../prettify.js"></script>

‎coverage/lcov-report/shared/easy-dom.js.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ <h1>
7676
</div><!-- /wrapper -->
7777
<div class='footer quiet pad2 space-top1 center small'>
7878
Code coverage
79-
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Thu Nov 09 2017 10:29:51 GMT-0300 (-03)
79+
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Thu Nov 09 2017 10:35:34 GMT-0300 (-03)
8080
</div>
8181
</div>
8282
<script src="../prettify.js"></script>

‎coverage/lcov-report/shared/index.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ <h1>
103103
</div><!-- /wrapper -->
104104
<div class='footer quiet pad2 space-top1 center small'>
105105
Code coverage
106-
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Thu Nov 09 2017 10:29:51 GMT-0300 (-03)
106+
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Thu Nov 09 2017 10:35:34 GMT-0300 (-03)
107107
</div>
108108
</div>
109109
<script src="../prettify.js"></script>

‎coverage/lcov-report/shared/poorlyfills.js.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ <h1>
235235
</div><!-- /wrapper -->
236236
<div class='footer quiet pad2 space-top1 center small'>
237237
Code coverage
238-
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Thu Nov 09 2017 10:29:51 GMT-0300 (-03)
238+
generated by <a href="http://istanbul-js.org/" target="_blank">istanbul</a> at Thu Nov 09 2017 10:35:34 GMT-0300 (-03)
239239
</div>
240240
</div>
241241
<script src="../prettify.js"></script>

‎esm/objects/Updates.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ function Cache() {}
2424
Cache.prototype = Object.create(null);
2525

2626
const asHTML = html => ({html});
27+
const attributeChangedCallback = () => {};
2728

2829
const create = (root, paths) => {
2930
const updates = [];
@@ -257,9 +258,8 @@ const setAttribute = (node, name) => {
257258
}
258259
};
259260
} else {
260-
let noOwner = false;
261-
const attribute = node.ownerDocument.createAttributeNode(name);
262-
node.setAttributeNode(attribute);
261+
let noOwner = true;
262+
const attribute = node.ownerDocument.createAttribute(name);
263263
return newValue => {
264264
if (oldValue !== newValue) {
265265
oldValue = newValue;

‎index.v2.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -628,6 +628,7 @@ var hyperHTML = function (cache, modules) {
628628
var asHTML = function asHTML(html) {
629629
return { html: html };
630630
};
631+
var attributeChangedCallback = function attributeChangedCallback() {};
631632

632633
var create = function create(root, paths) {
633634
var updates = [];
@@ -848,9 +849,8 @@ var hyperHTML = function (cache, modules) {
848849
}
849850
};
850851
} else {
851-
var noOwner = false;
852-
var attribute = node.ownerDocument.createAttributeNode(name);
853-
node.setAttributeNode(attribute);
852+
var noOwner = true;
853+
var attribute = node.ownerDocument.createAttribute(name);
854854
return function (newValue) {
855855
if (oldValue !== newValue) {
856856
oldValue = newValue;

‎min.v2.js‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎test/ce.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<!doctype html>
2-
<script src="../index.v2.js"></script>
2+
<script src="../index.v2.js?1"></script>
33
<script>
44
class TestCase extends HTMLElement {
55
static get observedAttributes() { return ['with']; }

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.




Check this box to remove all script contents from the fetched content.



Check this box to remove all images from the fetched content.


Check this box to remove all CSS styles from the fetched content.


Check this box to keep images inefficiently compressed and original size.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy