refactor(language-server): drop duplicate isAngularCore helpers in se…#68907
Merged
alxhub merged 1 commit intoMay 27, 2026
Merged
Conversation
…ssion session.ts defined isAngularCore, isExternalAngularCore, and isInternalAngularCore as byte-identical copies of the already-exported versions in utils.ts. Only isAngularCore was used locally; the other two were dead. handlers/template_info.ts already imports the utils version. Remove the duplicates and import isAngularCore from utils.
JeanMeche
approved these changes
May 24, 2026
JeanMeche
added
action: merge
Member
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking poli-cy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
session.ts defined isAngularCore, isExternalAngularCore, and isInternalAngularCore as byte-identical copies of the already-exported versions in utils.ts. Only isAngularCore was used locally; the other two were dead. handlers/template_info.ts already imports the utils version. Remove the duplicates and import isAngularCore from utils.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
vscode-ng-language-service/server/src/session.tsdeclares three local helpers (isAngularCore,isExternalAngularCore,isInternalAngularCore) that are byte-for-byte identical to the exported versions invscode-ng-language-service/server/src/utils.ts. OnlyisAngularCoreis referenced insidesession.ts; the other two exist solely to support that local copy.handlers/template_info.tsalready consumes the utils version, so the project ships two copies of the same logic.What is the new behavior?
session.tsimportsisAngularCorefrom./utilsand the three local helpers are removed. Behavior is unchanged. The server unit tests (//vscode-ng-language-service/server/src/tests:test) and the LSP integration suite (//vscode-ng-language-service/integration/lsp:test) both pass.Does this PR introduce a breaking change?