Improve Defer Trigger Misconfiguration#67497
Open
SkyZeroZx wants to merge 2 commits intoangular:mainfrom
Open
Conversation
angular-robot
bot
added
detected: feature
This comment was marked as outdated.
This comment was marked as outdated.
Extends the extended diagnostic for `@defer` trigger misconfiguration to include `on idle` triggers
Emit a warning when an `@defer` block uses `prefetch` triggers but does not define an explicit main trigger. Closes angular#52746
SkyZeroZx
force-pushed
the
refactor/improve-defer-diagnostic
branch
from
46007c8 to
e3e7aac
Compare
JeanMeche
added
state: blocked on G3 cleanup
Member
|
As expected this will require a cleanup on our side to land. There are a few |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top #65553
Add two commits
Add diagnostics for idle prefetch triggers
Since adding support for
@defer (on idle(500ms)), someidle+prefetchtiming combinations are not detected correctly.@defer (on idle(500ms); prefetch on idle(200ms) ) { <heavy-comp /> }Currently, this throws an error that is actually incorrect
Adds warning for prefetch without main defer trigger
Relative to #52746 and according examples in documentation
For example
@defer (prefetch when someFlag) { <heavy-comp /> }This configuration may suggest that the prefetch will only run when someFlag becomes true.
However, since the main trigger still defaults to on idle, the deferred content can be fetched earlier during the browser’s idle period, effectively bypassing the intended condition.
Closes #52746