perf(core): detect existing signal dependency without checking all pr…#67506
Open
JoostK wants to merge 1 commit intoangular:mainfrom
Open
perf(core): detect existing signal dependency without checking all pr…#67506JoostK wants to merge 1 commit intoangular:mainfrom
JoostK wants to merge 1 commit intoangular:mainfrom
Conversation
angular-robot
bot
added
area: performance
AndrewKushnir
requested review from
alxhub and
pkozlowski-opensource
and removed request for
AndrewKushnir
JoostK
added
the
action: cleanup
JoostK
force-pushed
the
signals/link-insertion-perf
branch
from
d1029a1 to
ac1c95b
Compare
JoostK
removed
the
action: cleanup
…oducer links This commit addresses a scaling issue in the signal dependency graph where the detection of duplicate dependency links would perform a linear scan across all consumer links of all producers. The linear scan is replaced with a version comparison of the dependency edge against the current epoch; if they are equal the existing dependency edge is known to be valid in this epoch. This means that the link won't be eligible for removal and therefore doesn't have to be recreated. Closes angular#67454
JoostK
force-pushed
the
signals/link-insertion-perf
branch
from
ac1c95b to
bb41616
Compare
milomg
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…oducer links
This commit addresses a scaling issue in the signal dependency graph where the detection of duplicate dependency links would perform a linear scan across all consumer links of all producers. The linear scan is replaced with a version comparison of the dependency edge against the version of the node; if they are equal the existing dependency edge is valid.
Closes #67454