feat(forms): add hasError to signal forms field state#67691
Open
adam-l wants to merge 2 commits intoangular:mainfrom
Open
feat(forms): add hasError to signal forms field state#67691adam-l wants to merge 2 commits intoangular:mainfrom
adam-l wants to merge 2 commits intoangular:mainfrom
Conversation
angular-robot
bot
added
detected: feature
adam-l
force-pushed
the
feat/signal-forms-has-error
branch
2 times, most recently
from
eea5413 to
826ca61
Compare
Add a `hasError(kind)` helper on Signal Forms field state. This avoids relying on positional access to `errors()`, such as `errors()[0]`, when rendering validation messages in templates and brings the API closer to the `hasError()` helper available on reactive forms controls. Closes angular#66624 Related to angular#63905
Add coverage for the new `hasError(kind)` helper on Signal Forms field state. Verify that it returns true for matching error kinds and false otherwise, including when multiple validation errors are present.
adam-l
force-pushed
the
feat/signal-forms-has-error
branch
from
826ca61 to
75005c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
hasError(kind)helper to Signal Forms field state.This makes it easier to check for specific validation errors in templates without
depending on positional access to
errors(), such aserrors()[0]orerrors()[1].The new helper helps avoid "magic numbers" when rendering validation messages.
Closes #66624
Related to #63905
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Signal Forms field state exposes
errors(), but it does not provide a direct way to check whether a field currently has a validation error of a specific kind.As a result, templates may need to inspect the returned error array directly, which can lead to patterns that depend on error ordering and the use of "magic numbers" such as
errors()[0]anderrors()[1].Issue Number: N/A
What is the new behavior?
Signal Forms field state now provides a
hasError(kind)helper that returns whether the field currently has a validation error of the given kind.This allows templates to check for specific validation errors directly and helps avoid "magic numbers" when rendering validation messages.
Does this PR introduce a breaking change?