feat(forms): adding event in submit for forms#67696
feat(forms): adding event in submit for forms#67696Wassaf001 wants to merge 1 commit intoangular:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Would this work?? |
|
Hi, thanks for your contribution Could you amend the message to something like Also, please make sure you sign the Google CLA |
Wassaf001
changed the title
JeanMeche
requested review from
leonsenft
and removed request for
AndrewKushnir
|
I have completed the CLA. |
leonsenft
left a comment
leonsenft
left a comment
There was a problem hiding this comment.
Could you please add a test that verifies the FormRoot directive correctly forwards the submit event with the corresponding submitter. Let me know if you need assistance at all.
| action: ( | ||
| field: FieldTree<TRootModel & TSubmittedModel>, | ||
| detail: {root: FieldTree<TRootModel>; submitted: FieldTree<TSubmittedModel>}, | ||
| event?: Event, |
There was a problem hiding this comment.
Lets move the event parameter to a property of the detail parameter.
It should also be a SubmitEvent so that the type exposes the submitter property: https://developer.mozilla.org/en-US/docs/Web/API/SubmitEvent.
There was a problem hiding this comment.
Also please run pnpm run public-api:update to update the public api
4 participants
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
#67334
Issue Number: 67334
What is the new behavior?
Does this PR introduce a breaking change?
Other information