-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat(new study screen): show ripple in answers' button click #19085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeking alternative functionality here.
I would like to see this, but not to the extent that it impacts users going through cards as quickly as possible
AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/AnswerButton.kt
Outdated
Show resolved
Hide resolved
setNextTime(nextTime) | ||
} | ||
companion object { | ||
private const val CLICK_DELAY_MS = 125L |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you look into another way of doing this, for example: triggering the ripple immediately on the ACTION_DOWN
.
Over long sessions (especially for med students) 2 x 125ms, adds up
Over a medical degree, that's days of people's time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you look into another way of doing this, for example: triggering the ripple immediately on the ACTION_DOWN.
Already the default behavior of buttons.
Reduced to 100ms, which is the bare minimum I found acceptable to see the ripple properly.
And honestly, I find that this is trying to micro-optimize too much. 1/10th of a second after taking an action is negligible. The old reviewer takes roughly the same or more than that, and nobody is complaining.
If someone is a machine, doesn't need 100ms to breathe or think, and only care about speed, use gestures or keybinds. They work instantly.
ea14a59
to
a96429f
Compare
more verbose, but reduces the base indent of the class generated by ktlint
a96429f
to
37a3ce5
Compare
it improves the feedback of answering a button
it improves the feedback of answering a button
Approach
In the commits
How Has This Been Tested?
Galaxy Tab S9, Android 15
Screen_Recording_20250813_173011_AnkiDroid.mp4
Checklist
Please, go through these checks before submitting the PR.