pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

URL: http://github.com/ankidroid/Anki-Android/pull/19085

ss" /> feat(new study screen): show ripple in answers' button click by BrayanDSO · Pull Request #19085 · ankidroid/Anki-Android · GitHub
Skip to content

Conversation

BrayanDSO
Copy link
Member

it improves the feedback of answering a button

Approach

In the commits

How Has This Been Tested?

Galaxy Tab S9, Android 15

Screen_Recording_20250813_173011_AnkiDroid.mp4

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeking alternative functionality here.

I would like to see this, but not to the extent that it impacts users going through cards as quickly as possible

setNextTime(nextTime)
}
companion object {
private const val CLICK_DELAY_MS = 125L
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you look into another way of doing this, for example: triggering the ripple immediately on the ACTION_DOWN.

Over long sessions (especially for med students) 2 x 125ms, adds up

Over a medical degree, that's days of people's time

Copy link
Member Author

@BrayanDSO BrayanDSO Aug 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you look into another way of doing this, for example: triggering the ripple immediately on the ACTION_DOWN.

Already the default behavior of buttons.

Reduced to 100ms, which is the bare minimum I found acceptable to see the ripple properly.

And honestly, I find that this is trying to micro-optimize too much. 1/10th of a second after taking an action is negligible. The old reviewer takes roughly the same or more than that, and nobody is complaining.

If someone is a machine, doesn't need 100ms to breathe or think, and only care about speed, use gestures or keybinds. They work instantly.

more verbose, but reduces the base indent of the class generated by ktlint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.





Check this box to remove all script contents from the fetched content.



Check this box to remove all images from the fetched content.


Check this box to remove all CSS styles from the fetched content.


Check this box to keep images inefficiently compressed and original size.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy