GH-49563: [C++][FlightRPC][ODBC] Remove libunwind dynamic linked library in macOS Intel CI#49575
Open
alinaliBQ wants to merge 1 commit intoapache:mainfrom
Open
GH-49563: [C++][FlightRPC][ODBC] Remove libunwind dynamic linked library in macOS Intel CI#49575alinaliBQ wants to merge 1 commit intoapache:mainfrom
alinaliBQ wants to merge 1 commit intoapache:mainfrom
Conversation
Currently CLANG_TOOLS_PATH path is resolved as /usr/local/bin/clang-format. This is likely due to a new macOS update mentioned in xpack-dev-tools/clang-xpack#13. Before the GitHub macOS update, CLANG_TOOLS_PATH was resolved as /usr/local/opt/llvm@18/bin and we did not have the issue of libunwind linking dynamically to ODBC dylib. The solution is to explicitly set CLANG_TOOLS_PATH to llvm@18/bin.
|
|
github-actions
bot
added
CI: Extra: C++
alinaliBQ
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
GH-49563
What changes are included in this PR?
This issue occurred without any code changes, so I think it is due to an macOS update.
After a GitHub macOS update, the
CLANG_TOOLS_PATHpath is resolved as/usr/local/bin/clang-formatin Intel CI. Before the GitHub macOS update,CLANG_TOOLS_PATHwas resolved as/usr/local/opt/llvm@18/binand we did not have the issue oflibunwindlinking dynamically to ODBC dylib.The solution is to explicitly set
CLANG_TOOLS_PATHtollvm@18/binon Intel machines.Are these changes tested?
Are there any user-facing changes?
N/A
libunwindin macOS Intel CI #49563