pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!

julien-vaz · 2025-03-05T14:07:53Z

Description

In the current version, the quotaStatement API is returning the internal ID for account and domain, which is not useful for users, since all APIs use/return the UUID. Also, when the usage_type parameter is informed, the API shows dummy records.

To address those problems:

the API was modified so it returns the resources' UUID;
the dummy records bug was fixed;
a new parameter showresources was added to display more information to the user about each usage type;
a new quotaStatementDetails API was created to list more details about each usage type;

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

How Has This Been Tested?

On CloudMonkey the quotaStatement API was called and:

the resources' UUID was returned instead of the internal ID;
when specified a usage_type no dummy records were showed;
the showresources parameter is properly working;

The quotaStatementDetails API was called successfully as well.

julien-vaz · 2025-03-05T17:01:42Z

@blueorangutan package

blueorangutan · 2025-03-05T17:04:04Z

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-05T18:23:20Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12669

codecov · 2025-03-05T21:05:34Z

Codecov Report

❌ Patch coverage is 23.44498% with 320 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.02%. Comparing base (3166e64) to head (ce5d96a).

Files with missing lines	Patch %	Lines
...udstack/api/response/QuotaResponseBuilderImpl.java	32.05%	105 Missing and 1 partial ⚠️
...g/apache/cloudstack/quota/vo/QuotaUsageJoinVO.java	35.41%	62 Missing ⚠️
...he/cloudstack/quota/dao/QuotaUsageJoinDaoImpl.java	0.00%	37 Missing ⚠️
...apache/cloudstack/quota/vo/QuotaUsageDetailVO.java	0.00%	31 Missing ⚠️
...ache/cloudstack/quota/vo/QuotaUsageResourceVO.java	0.00%	27 Missing ⚠️
...ache/cloudstack/api/command/QuotaStatementCmd.java	15.78%	16 Missing ⚠️
.../cloudstack/quota/dao/QuotaUsageDetailDaoImpl.java	0.00%	15 Missing ⚠️
...i/response/QuotaStatementItemResourceResponse.java	0.00%	13 Missing ⚠️
...loudstack/api/response/QuotaStatementResponse.java	36.36%	7 Missing ⚠️
...c/main/java/com/cloud/utils/db/SearchCriteria.java	0.00%	4 Missing ⚠️
... and 1 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #10506      +/-   ##
============================================
+ Coverage     18.01%   18.02%   +0.01%     
- Complexity    16607    16629      +22     
============================================
  Files          6029     6035       +6     
  Lines        542160   542455     +295     
  Branches      66451    66473      +22     
============================================
+ Hits          97682    97799     +117     
- Misses       433461   433643     +182     
+ Partials      11017    11013       -4

Flag	Coverage Δ
uitests	`3.52% <ø> (ø)`
unittests	`19.18% <23.44%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

julien-vaz · 2025-03-06T17:16:19Z

@blueorangutan package

blueorangutan · 2025-03-06T17:18:05Z

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-06T17:40:29Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12689

…uotaServiceImplTest

julien-vaz · 2025-03-11T16:58:34Z

I've just successfully builded the packages locally with -Dnoredist. Therefore, I'm requesting the package building again

julien-vaz · 2025-03-11T16:58:52Z

@blueorangutan package

blueorangutan · 2025-03-11T17:00:04Z

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-11T18:15:32Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12742

lucas-a-martins

CLGTM

DaanHoogland

clgtm

DaanHoogland · 2025-04-16T06:05:17Z

+                    "accountName", "accountId", "domainId", "startDate", "endDate", "type", "showDetails")));
        }
+        logger.debug("Creating quota statement from [{}] usage records for parameters [{}].", quotaUsages.size(),
+                ReflectionToStringBuilderUtils.reflectOnlySelectedFields(cmd, "accountName", "accountId", "domainId", "startDate", "endDate", "type", "showDetails"));


this seems the reuse of the same array of strings. Not for this PR but maybe we should allow String[] as parameter for ReflectionToStringBuilderUtils.reflectOnlySelectedFields. Or allow some kind of predefined default per class to be registered.

sureshanaparti · 2025-06-05T09:24:46Z

@blueorangutan package

blueorangutan · 2025-06-05T09:26:06Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

nvazquez · 2025-10-01T01:00:26Z

Hi @julien-vaz is this PR ready for review? Looks like its missing SQL statements for new tables and views?

github-actions · 2025-10-16T09:11:49Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

winterhazel · 2026-04-07T20:17:17Z

Are schema changes missing here? Seeing some new VO classes but no corresponding SQL changes I can find

@shwstppr good catch, some schema changes are missing. I will add them.

…ment

winterhazel · 2026-04-08T21:18:37Z

@blueorangutan package

blueorangutan · 2026-04-08T21:20:05Z

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-04-08T22:10:33Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17410

github-actions · 2026-04-13T08:22:57Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

…ment

DaanHoogland · 2026-04-21T14:19:54Z

@blueorangutan package

blueorangutan · 2026-04-21T14:22:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-04-21T15:14:39Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17568

winterhazel · 2026-04-23T13:38:34Z

@blueorangutan package

Improve Quota Statement

9617344

boring-cyborg Bot added component:api component:database component:quota labels Mar 5, 2025

winterhazel added this to the 4.21.0 milestone Mar 5, 2025

winterhazel self-requested a review March 6, 2025 13:06

Removes unused import

e702bb3

Fix QuotaUsageJoinDao, QuotaResponseBuilderImpl, QuotaServiceImpl e Q…

0a996dc

…uotaServiceImplTest

DaanHoogland reviewed Mar 12, 2025

View reviewed changes

Comment thread plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaStatementCmd.java Outdated

Comment thread ...atabase/quota/src/main/java/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java Outdated

Julien Hervot de Mattos Vaz added 2 commits March 12, 2025 11:45

Reorganize imports

7d06715

Updates QuotaStatementCmd responseBuilder scope to default

58c0b5c

lucas-a-martins approved these changes Apr 15, 2025

View reviewed changes

DaanHoogland approved these changes Apr 16, 2025

View reviewed changes

bernardodemarco self-requested a review June 4, 2025 17:38

Fix log4j syntax

412a4bd

sureshanaparti added this to Apache CloudStack 4.21.0 Jun 5, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Jun 5, 2025

RosiKyu assigned RosiKyu and unassigned RosiKyu Oct 13, 2025

github-actions Bot added the status:has-conflicts label Oct 16, 2025

harikrishna-patnala modified the milestones: 4.22.0, 4.22.1 Nov 12, 2025

harikrishna-patnala removed this from Apache CloudStack 4.22.0 Nov 12, 2025

winterhazel modified the milestones: 4.22.1, 4.23.0 Dec 20, 2025

winterhazel self-assigned this Feb 3, 2026

winterhazel added 4 commits April 8, 2026 16:16

Address reviews + other improvements

bb32371

Merge remote-tracking branch 'upstream/main' into improve-quota-state…

f5c8d84

…ment

Add missing SQL scripts and injections

d05ab01

Change accountid and domainid logic + add unit tests

fdeb202

winterhazel removed the status:has-conflicts label Apr 8, 2026

github-actions Bot added the status:has-conflicts label Apr 13, 2026

Merge remote-tracking branch 'upstream/main' into improve-quota-state…

ce5d96a

…ment

winterhazel removed the status:has-conflicts label Apr 20, 2026

Rename QuotaUsageDetail to QuotaTariffUsage

31966d7

Fix out of bounds exception

1f39686

pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!

Conversation

julien-vaz commented Mar 5, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

How Has This Been Tested?

Uh oh!

julien-vaz commented Mar 5, 2025

Uh oh!

blueorangutan commented Mar 5, 2025

Uh oh!

blueorangutan commented Mar 5, 2025

Uh oh!

codecov Bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

julien-vaz commented Mar 6, 2025

Uh oh!

blueorangutan commented Mar 6, 2025

Uh oh!

blueorangutan commented Mar 6, 2025

Uh oh!

julien-vaz commented Mar 11, 2025

Uh oh!

julien-vaz commented Mar 11, 2025

Uh oh!

blueorangutan commented Mar 11, 2025

Uh oh!

blueorangutan commented Mar 11, 2025

Uh oh!

Uh oh!

Uh oh!

lucas-a-martins left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sureshanaparti commented Jun 5, 2025

Uh oh!

blueorangutan commented Jun 5, 2025

Uh oh!

nvazquez commented Oct 1, 2025

Uh oh!

github-actions Bot commented Oct 16, 2025

Uh oh!

winterhazel commented Apr 7, 2026

Uh oh!

winterhazel commented Apr 8, 2026

Uh oh!

blueorangutan commented Apr 8, 2026

Uh oh!

blueorangutan commented Apr 8, 2026

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

DaanHoogland commented Apr 21, 2026

Uh oh!

blueorangutan commented Apr 21, 2026

Uh oh!

blueorangutan commented Apr 21, 2026

Uh oh!

winterhazel commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.

codecov Bot commented Mar 5, 2025 •

edited

Loading