Merged
Conversation
WZhuo
force-pushed
the
incremental_append_scan
branch
3 times, most recently
from
9b822d0 to
4c4ffff
Compare
wgtmac
reviewed
Mar 20, 2026
wgtmac
reviewed
Mar 20, 2026
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
Note: This review was generated by Gemini.
wgtmac
reviewed
Mar 20, 2026
WZhuo
force-pushed
the
incremental_append_scan
branch
2 times, most recently
from
d1bacdf to
5c41a78
Compare
WZhuo
force-pushed
the
incremental_append_scan
branch
2 times, most recently
from
3f97b02 to
8e2ad99
Compare
wgtmac
requested changes
Mar 25, 2026
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
Note: This review was generated by Gemini.
Summary & Recommendation
- Request Changes: There are logic bugs in handling empty table snapshots and a potential hashing/equality discrepancy for manifest files that need to be addressed.
Member
|
Mostly look good. I will merge this after two remaining issues have been addressed. |
…nstantiate in header
WZhuo
force-pushed
the
incremental_append_scan
branch
from
8e2ad99 to
f3cd338
Compare
wgtmac
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.