Merged
Conversation
wgtmac
commented
Mar 25, 2026
| Status RoaringPositionBitmap::Add(int64_t pos) { | ||
| ICEBERG_RETURN_UNEXPECTED(ValidatePosition(pos)); | ||
| void RoaringPositionBitmap::Add(int64_t pos) { | ||
| if (pos < 0 || pos > kMaxPosition) { |
Member
Author
There was a problem hiding this comment.
@emkornfield I've changed this to not fail on invalid inputs.
Contributor
There was a problem hiding this comment.
I'm OK with this, i think this case is a little bit less clear then the read side though.
emkornfield
approved these changes
Mar 25, 2026
evindj
approved these changes
Mar 26, 2026
blackmwk
approved these changes
Mar 28, 2026
Member
Author
|
Thanks all for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.