Add timestamp ns literal#3298
Open
rambleraptor wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@geruh @kevinjqliu found this while working on equality deletes + type promotion stuff. Should be pretty straight forward. ptal, thanks for your time! |
Fokko
reviewed
May 4, 2026
Comment on lines
+342
to
+348
| @to.register(TimestampNanoType) | ||
| def _(self, _: TimestampNanoType) -> Literal[int]: | ||
| return TimestampNanoLiteral(self.value) | ||
|
|
||
| @to.register(TimestamptzNanoType) | ||
| def _(self, _: TimestamptzNanoType) -> Literal[int]: | ||
| return TimestampNanoLiteral(self.value) |
Contributor
There was a problem hiding this comment.
Unfortunally, this has been shown to be controversial in the Iceberg-Java implementation: apache/iceberg#11775 (comment)
If you think about it in SQL: SELECT * FROM tbl WHERE dt > 1777883174. This assumes that the int is micros. However, when you would widen the field dt by converting it from micros to nanos, then the query would return a different result. When we would bind the LongLiteral to TimestampNanoLiteral we implicitly assume that it is a nanos after the widening of the column.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Ran into this with the type promotion rabbit hole I've found myself in.
Turns out we don't have literal types for
timestamp_ns. This is definitely a missing part of being able to use timestamp_ns types.My goal here was to match the microsecond usage as much as possible.
(There's some weirdness for converting these to strings, since Python's string format doesn't actually handle nano-seconds for us. What fun!)
Are these changes tested?
Added some tests.
Are there any user-facing changes?