Fix #5627: SFT example notebook references inaccessible S3 dataset URI#5704
Open
JiwaniZakir wants to merge 1 commit intoaws:masterfrom
Open
Fix #5627: SFT example notebook references inaccessible S3 dataset URI#5704JiwaniZakir wants to merge 1 commit intoaws:masterfrom
JiwaniZakir wants to merge 1 commit intoaws:masterfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
JiwaniZakir
requested a deployment
to
manual-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5627
Motivation
The SFT finetuning example notebook hardcoded an internal S3 URI (
s3://mc-flows-sdk-testing/...) that external users cannot access, causing an immediate 403 Forbidden error when running the dataset registration cell.Changes
File:
v3-examples/model-customization-examples/sft_finetuning_example_notebook_pysdk_prod_v3.ipynbs3://mc-flows-sdk-testing/input_data/sft/sample_data_256_final.jsonlsource with a named placeholder variableMY_DATASET_S3_URI = "s3://<your-bucket>/<path-to-your-dataset>.jsonl"marked with a# TODOcomment. Added an explanatory comment block describing the required JSONL format (prompt/completionfields per line) and linking to the SageMaker SFT documentation.s3_output_path="s3://mc-flows-sdk-testing/output/"with"s3://<your-bucket>/output/"and a# TODOcomment.s3_output_pathsubstitution as above.s3_output_path="s3://mc-flows-sdk-testing-us-east-1/output/"with the same placeholder pattern.Testing
Manual verification: open the notebook and confirm no cells reference
mc-flows-sdk-testing— all four occurrences are replaced with<your-bucket>placeholders. A user following the notebook will now see theTODOmarkers before executing any cell that requires S3 access, preventing the 403 error. Substituting a valid bucket and a JSONL file withprompt/completionfields allows the notebook to run end-to-end successfully.