Fix //src/main/cpp:client link with MinGW#28771
Draft
fmeum wants to merge 2 commits intobazelbuild:masterfrom
Draft
Fix //src/main/cpp:client link with MinGW#28771fmeum wants to merge 2 commits intobazelbuild:masterfrom
//src/main/cpp:client link with MinGW#28771fmeum wants to merge 2 commits intobazelbuild:masterfrom
Conversation
* Replace `select`s on flags for Windows with the appropriate compiler constraints. Also update `blake3`, which contains the same type of fix in its most recent version. * Ditch the `cmd.exe` implementation of `merge_licenses` that incorrectly matched on the target rather than the exec platform. Bash is already a requirement for Bazel at this point, so we might as well use it. * Drop the explicit C++17 standard flags since this is already the default standard in Bazel@HEAD.
fmeum
changed the title
//src/main/cpp:client link with MinGW
Collaborator
Author
|
Stacked on #28751 |
github-actions
bot
added
team-Rules-CPP
Collaborator
Author
|
@bazel-io fork 9.1.0 |
Member
|
Please ping me when this is ready for import |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linking the Bazel client requires a number of explicit library linker args when using MinGW. This was missed in #28751.
Motivation
With this PR, Bazel can in principle be cross-compiled to Windows from Unix (except for the manifest patching in the minimize_jdk script, which currently only runs on a Windows executor).
Build API Changes
No
Checklist
Release Notes
RELNOTES: None