Fix --workspace_status_command empty value handling#28921
Open
wade-arista wants to merge 1 commit intobazelbuild:masterfrom
Open
Fix --workspace_status_command empty value handling#28921wade-arista wants to merge 1 commit intobazelbuild:masterfrom
wade-arista wants to merge 1 commit intobazelbuild:masterfrom
Conversation
parseWorkspaceStatus() was silently discarding lines without a space
due to input.trim() mangling trailing-space-at-EOF combined with the
key-only check skipping them. parseValues() had the same key-only
discard behavior.
Both now store an empty string for keys with no value, and skip
genuinely empty lines. Unit tests added for both parsers covering
key-only, trailing-space, and EOF edge cases.
Specific cases of interest:
1. Key only with no trailing space:
echo "KEY_ONLY"
echo "KEY_WITH_VALUE value"
2. Key only entry at EOF (trailing space optional):
echo "KEY_WITH_VALUE value"
echo "KEY_ONLY "
Fixes bazelbuild#16037
github-actions
bot
added
team-Configurability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
parseWorkspaceStatus() was silently discarding lines without a space due to input.trim() mangling trailing-space-at-EOF combined with the key-only check skipping them. parseValues() had the same key-only discard behavior.
Both now store an empty string for keys with no value, and skip genuinely empty lines. Unit tests added for both parsers covering key-only, trailing-space, and EOF edge cases.
Motivation
Specific cases of interest:
Key only with no trailing space:
echo "KEY_ONLY"
echo "KEY_WITH_VALUE value"
Key only entry at EOF (trailing space optional):
echo "KEY_WITH_VALUE value"
echo "KEY_ONLY "
Fixes #16037
Build API Changes
No
Checklist
Release Notes
RELNOTES: None