This repository was archived by the owner on Apr 9, 2021. It is now read-only.
Open
Conversation
added days parameter to clicks_by_day (accepting that this is depracated)
Contributor
Author
|
Since this pull request is untouched I'll provide a simple example to monkey-patch the bitly_api with the updated clicks_by_day method: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clicks_by_day parameter is deprecated but still works and it returns a historic list of clicks per day (unlike, as best I can tell, v3/link/clicks). clicks_by_day accepts a 'days' parameter but this wasn't available in the Python bindings, I've added the option along with 2 new tests.
I've also checked in some pep8 pedantry.