This change moves the optional and suggested comments#231
Open
ggolin wants to merge 1 commit intochaoss:masterfrom
Open
This change moves the optional and suggested comments#231ggolin wants to merge 1 commit intochaoss:masterfrom
optional and suggested comments#231ggolin wants to merge 1 commit intochaoss:masterfrom
Conversation
sduenas
requested changes
Jul 12, 2024
Member
sduenas
left a comment
sduenas
left a comment
There was a problem hiding this comment.
The PR looks good to me but can you add to the commit the Signed-off trailer? All contributions need to be signed: https://github.com/chaoss/grimoirelab/blob/master/CONTRIBUTING_WITH_CODE.md#developer-certificate-origen
Thanks!
Member
|
Hi @ggolin, do you need any help for completing this? Let me know if it’s okay for me to take it up, as it has been a pressing issue for a long time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change: as reported on Slack, mordred consumes comments as part of the configured value, so folks who copy-paste configuration from the documentation run into cryptic errors, for example:
setup.cfg
Error:
Removing the comment
# (optional)fixes this issue.