Add trailing newline to markdown report#1936
Draft
rgryta wants to merge 2 commits into
Draft
Conversation
Without trailing newline in a markdown report, the first additional information that comes from cmdline handler will end up in an additional row below the TOTALs row. E.g. Coverage failure: https://github.com/nedbat/coveragepy/blob/master/coverage/cmdline.py#L761
Member
|
Will you be fixing the failing tests? |
Author
Hi, yes. Haven't had time to work on them this weekend. I'll change the last_line assertions to second_last_line. I can add those changes in any way tbh. |
Member
|
I think I'd change the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without trailing newline in a markdown report, the first additional information that comes from cmdline handler will end up in an additional row below the TOTALs row.
E.g. Coverage failure: https://github.com/nedbat/coveragepy/blob/master/coverage/cmdline.py#L761