Fix NumPy signature mismatch for cupy.argmax#9767
Open
Punit200320 wants to merge 4 commits intocupy:mainfrom
Open
Fix NumPy signature mismatch for cupy.argmax#9767Punit200320 wants to merge 4 commits intocupy:mainfrom
Punit200320 wants to merge 4 commits intocupy:mainfrom
Conversation
Member
|
Thanks for looking into this. I am confirming with others, but to me We also need to make sure to do two other things:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the function signature mismatch between NumPy and CuPy for
cupy.argmax.The
dtypeargument has been removed from the CuPy API to align with NumPy's signature:numpy.argmax(a, axis=None, out=None, keepdims=False)
This improves API compatibility between NumPy and CuPy.