Ensure mounted transports are closed even if main transport raises#3769
Open
bysiber wants to merge 1 commit intoencode:masterfrom
Open
Ensure mounted transports are closed even if main transport raises#3769bysiber wants to merge 1 commit intoencode:masterfrom
bysiber wants to merge 1 commit intoencode:masterfrom
Conversation
When closing a client with proxy mounts, if the main transport's close/exit raises an exception, the mounted transports would never be cleaned up. This could lead to leaked connections. Wrap the main transport cleanup in try/finally to ensure mounted transports are always properly closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When closing a client with proxy mounts, if the main transport's
close()/__exit__()raises an exception, the mounted proxy transports would never be cleaned up. This wraps transport cleanup intry/finallyto ensure all transports are properly closed.Affects
Client.close(),Client.__exit__(),AsyncClient.aclose(), andAsyncClient.__aexit__().