pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

URL: http://github.com/executablebooks/sphinx-design/pull/205

52276e82f63bb403.css" /> refactor: Remove unused constants by ftnext · Pull Request #205 · executablebooks/sphinx-design · GitHub
Skip to content

refactor: Remove unused constants#205

Open
ftnext wants to merge 1 commit intoexecutablebooks:mainfrom
ftnext:octicon-role-unused-constants
Open

refactor: Remove unused constants#205
ftnext wants to merge 1 commit intoexecutablebooks:mainfrom
ftnext:octicon-role-unused-constants

Conversation

@ftnext
Copy link

@ftnext ftnext commented Jul 1, 2024

Thank you for this awesome library.
I referred to the implementation of the octicon role in icons.py (a3bdfa3).

In reading the implementation, I noticed some unused code, so I propose to remove it.

$ git grep OCTICON_CSS
sphinx_design/icons.py:OCTICON_CSS = """\
$ git grep OCTICON_VERSION
sphinx_design/icons.py:OCTICON_VERSION = "v19.8.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ftnext
pFad - Phonifier reborn

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.




Check this box to remove all script contents from the fetched content.



Check this box to remove all images from the fetched content.


Check this box to remove all CSS styles from the fetched content.


Check this box to keep images inefficiently compressed and original size.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy