Fix boundary event iterator desynchronization in ContinueProcessOperation#4158
Open
uucoding wants to merge 4 commits intoflowable:mainfrom
Open
Fix boundary event iterator desynchronization in ContinueProcessOperation#4158uucoding wants to merge 4 commits intoflowable:mainfrom
uucoding wants to merge 4 commits intoflowable:mainfrom
Conversation
…tion **The `executeBoundaryEvents` method had a critical iterator desynchronization bug. The `while` loop assumed that the `boundaryEvents` and `boundaryEventExecutions` lists contained matching elements in the same order, but they did not due to inconsistent filtering.** **For example:** - `createBoundaryEvents` returns only: `[TimerExec, ErrorExec]` (compensation events are skipped) - `executeBoundaryEvents` receives: `[Timer, Compensation, Error]` (all events) **Loop pairing comparison:** ``` Expected pairing: Actual incorrect pairing: Timer ↔ TimerExec ✓ Timer ↔ TimerExec ✓ Error ↔ ErrorExec ✓ Compensation ↔ ErrorExec ✗ ```
…sOperation Fix boundary event iterator desynchronization in ContinueProcessOpera…
Contributor
|
@uucoding can you please write a test case for this? |
Author
Author
|
Hi @filiphr , Hope you're doing well! Just circling back on the test case I submitted last month for the boundary event iterator desynchronization fix. When you have a moment, could you please review it and let me know if any changes are needed? Thanks so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
executeBoundaryEventsmethod had a critical iterator desynchronization bug. Thewhileloop assumed that theboundaryEventsandboundaryEventExecutionslists contained matching elements in the same order, but they did not due to inconsistent filtering.For example:
createBoundaryEventsreturns only:[TimerExec, ErrorExec](compensation events are skipped)executeBoundaryEventsreceives:[Timer, Compensation, Error](all events)Loop pairing comparison: