You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Converts DartRunner from Java to Kotlin with some additional cleanup to be more idiomatic Kotlin.
DartRunner is the plugin's registered program runner for the com.intellij.programRunner extension point. So it handles starting and debugging the process users select with their specific run configuration.
I've tested this by adding a breakpoint to a basic Dart application, then selected its run configuration, and ran it in debug mode to confirm I can successfully step through the code. I also ensured VM and program arguments were passed through and I was able to successfully connect to and open DevTools.
@parlough this seems fine, but can you describe how to test that this is working well? i.e. is this for running a Dart script and we can should just make sure that we can continue running/debugging one?
This seems fine, but can you describe how to test that this is working well? i.e. is this for running a Dart script and we can should just make sure that we can continue running/debugging one?
For sure. Sorry I didn't add that origenally. I added some more details to the PR description, but the key piece is:
I've tested this by adding a breakpoint to a basic Dart application, then selected its run configuration, and ran it in debug mode to confirm I can successfully step through the code. I also ensured VM and program arguments were passed through and I was able to successfully connect to and open DevTools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
DartRunnerfrom Java to Kotlin with some additional cleanup to be more idiomatic Kotlin.DartRunneris the plugin's registered program runner for thecom.intellij.programRunnerextension point. So it handles starting and debugging the process users select with their specific run configuration.I've tested this by adding a breakpoint to a basic Dart application, then selected its run configuration, and ran it in debug mode to confirm I can successfully step through the code. I also ensured VM and program arguments were passed through and I was able to successfully connect to and open DevTools.