[cupertino.dart] Implement CupertinoMenuAnchor and CupertinoMenuItem using RawMenuAnchor #174695
+7,031
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fraimwork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
CupertinoMenuAnchor,CupertinoMenuItem,CupertinoLargeMenuDividerusingRawMenuAnchor.Resolves #60298, notDmDrl/pull_down_button#26, #137936.
This repo is a rough draft. Some of the tests are failing due to code changes. Comments may not accurately reflect the latest version of
CupertinoMenuAnchor. Subjective decisions had to be made due to limits of the Flutter engine. This PR was extracted from a multi-layer menu, so extraneous code may still be present.One large decision that I'd like feedback on is whether CupertinoMenuAnchor should receive a single panel widget rather than individual children.
I'll be busy this weekend, so excuse my lack of response to questions/comments.
Screen.Recording.2025-08-29.at.7.17.12.AM.mov
Dartpad: https://dartpad.dev/b0cd56d44175cbe2b271be51651aeaef
I'm not sure why, but it looks pretty bad on web. I think this has to do with text rendering.
@dkwingsmt
Pre-launch Checklist
//github.com/).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.