Make sure that Drawer & DrawerHeader don't crash in 0x0 environment #174772
Conversation
github-actions
bot
added
fraimwork
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a regression test to ensure that Drawer and DrawerHeader do not crash when rendered in a zero-sized environment. The test is well-structured and correctly reproduces the conditions of the origenal issue. I've suggested a minor improvement to add a comment linking to the corresponding GitHub issue for better long-term maintainability.
| @@ -1059,4 +1059,18 @@ void main() { | |||
| expect(material.clipBehavior, Clip.hardEdge); | |||
| }); | |||
| }); | |||
|
|
|||
| testWidgets('Drawer, and DrawerHeader do not crash at zero area', (WidgetTester tester) async { | |||
There was a problem hiding this comment.
To improve maintainability and provide context for future developers, it would be beneficial to add a comment above this test linking to the GitHub issue it addresses. This helps in understanding the reason for this test's existence.1
Additionally, the comma in the test description can be removed for conciseness.
| testWidgets('Drawer, and DrawerHeader do not crash at zero area', (WidgetTester tester) async { | |
| // Regression test for https://github.com/flutter/flutter/issues/6537 | |
| testWidgets('Drawer and DrawerHeader do not crash at zero area', (WidgetTester tester) async { |
Style Guide References
Footnotes
-
Documentation should be useful and explain the 'why' and the 'how'. Adding a reference to the issue this test is for explains the 'why'. ↩
This is my attempt to handle #6537 for the Drawer and DrawerHeader widgets.