Fix CupertinoNavigationBar MediaQuery regression #174771 #174776
+135
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Since Flutter 3.35,
MediaQuery.of(context)
inside CupertinoNavigationBar components (trailing, leading, middle, etc.) returnsSize(0.0, 0.0)
instead of the correct screen dimensions. This regression breaks responsive logic and layout decisions made within navigation bar components.Root Cause
The issue occurs because CupertinoNavigationBar components wrap their child widgets with
MediaQuery
widgets that only providetextScaler
data usingMediaQueryData(textScaler: ...)
. When creating aMediaQueryData
with only specific properties, all other properties default to their initial values, causingsize
to default toSize.zero
.Affected components:
Solution
Replace
MediaQueryData()
constructors withMediaQuery.of(context).copyWith()
to preserve all existing MediaQuery properties (size, padding, devicePixelRatio, etc.) while only modifying the text scaling behavior.Changes
Core Fix
MediaQueryData
constructor calls inpackages/flutter/lib/src/cupertino/nav_bar.dart
size
,padding
,devicePixelRatio
and other properties are not reset to defaultsTesting
packages/flutter/test/cupertino/nav_bar_test.dart
Impact
Fixed Issues
Compatibility
Testing Instructions
To verify the fix:
Fixes #174771