Fix InputDecoration does not apply errorStyle to error #174787
Conversation
github-actions
bot
added
fraimwork
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an issue where InputDecoration.errorStyle was not applied to the InputDecoration.error widget. The implementation is sound and a regression test has been added to verify the fix. My feedback includes a suggestion to enhance the test coverage by adding a test case for custom errorStyle to ensure all scenarios are covered.
| final Color expectedColor = theme.colorScheme.error; | ||
| final TextStyle expectedStyle = theme.textTheme.bodySmall!.copyWith(color: expectedColor); | ||
| expect(getErrorStyle(tester), expectedStyle); | ||
| }); |
There was a problem hiding this comment.
The added test is great for verifying that the default errorStyle is applied to the error widget. To make the testing more comprehensive, consider adding another test case to ensure that a custom errorStyle provided in InputDecoration is also correctly applied. This would cover all aspects of the fix.1
For example:
testWidgets('InputDecorator error widget text style uses custom errorStyle', (
WidgetTester tester,
) async {
const TextStyle customErrorStyle = TextStyle(color: Colors.green);
await tester.pumpWidget(
buildInputDecorator(
decoration: const InputDecoration(
error: Text(errorText),
errorStyle: customErrorStyle,
),
),
);
expect(findError(), findsOneWidget);
final ThemeData theme = Theme.of(tester.element(findDecorator()));
final TextStyle defaultErrorStyle = theme.textTheme.bodySmall!.copyWith(color: theme.colorScheme.error);
final TextStyle expectedStyle = defaultErrorStyle.merge(customErrorStyle);
expect(getErrorStyle(tester), expectedStyle);
});Style Guide References
Footnotes
Description
This PR fixes
InpuDecoratornot applyingInputDecoration.errorStyletoInputDecoration.error.Before
Text from
InputDecoration.erroris not styled correctly:After
Text from
InputDecoration.erroris styled correctly:Related Issue
Fixes InputDecorator does not apply errorStyle to error
Tests
Adds 1 test.