[Android] Avoid plugin auto-registration during FlutterFragmentActivity recreate timing window#182963
Open
littleGnAl wants to merge 1 commit intoflutter:masterfrom
Conversation
…ty recreate timing window
github-actions
bot
added
platform-android
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a timing issue in FlutterFragmentActivity during activity recreation, which could lead to incorrect plugin auto-registration. The fix involves modifying configureFlutterEngine to explicitly check for an existing FlutterFragment from the FragmentManager if the activity's flutterFragment field is not yet populated. This prevents GeneratedPluginRegister.registerGeneratedPlugins from being called unnecessarily. The change is accompanied by two new unit tests: one to specifically validate the new logic in configureFlutterEngine, and another integration test using ActivityScenario to verify the fix during activity recreation with a cached engine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an Android embedding timing issue in
FlutterFragmentActivityduring Activity recreation.When an Activity is being recreated,
FragmentManagercan restore/attach an existingFlutterFragmentbeforeensureFlutterFragmentCreated()refreshes theflutterFragmentfield.In that window,
configureFlutterEngine()may run withflutterFragment == null, miss the injected-engine guard, and incorrectly callGeneratedPluginRegister.registerGeneratedPlugins(...).That can lead to unintended plugin lifecycle behavior in real apps.
Pre-launch Checklist
//github.com/).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.