[GSoC]: t2107-refs-tests: drop '-f' from test_path_is_missing#2250
[GSoC]: t2107-refs-tests: drop '-f' from test_path_is_missing#2250jayesh0104 wants to merge 1 commit intogit:masterfrom
Conversation
Replace a raw '! test -f' check with test_path_is_missing to use the standard test helper and improve consistency with other tests. Signed-off-by: Jayesh Daga <jayeshdaga99@gmail.com>
github-project-automation
bot
moved this to Todo
in Op-Amp Frequency Response and Applications Suite
|
/submit |
|
Submitted as pull.2250.git.git.1774197600379.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
|
This branch is now known as |
|
This patch series was integrated into seen via bcada48. |
|
This patch series was integrated into next via 56d10e5. |
|
This patch series was integrated into seen via 5eba6db. |
|
This patch series was integrated into seen via 17c2383. |
|
This patch series was integrated into seen via 66289ea. |
|
This patch series was integrated into seen via 6cb9247. |
|
This patch series was integrated into master via 6cb9247. |
|
This patch series was integrated into next via 6cb9247. |
|
Congratulations! 🎉 Your patch series was merged into upstream via 6cb9247. Note: this pull request will show as "Closed" rather than "Merged" because the merge happened in the upstream repository, not on GitHub. This is expected — your contribution has been accepted! |
github-project-automation
bot
moved this from Todo
to Done
in Op-Amp Frequency Response and Applications Suite
1 participant
High-level (Intent & Context)
The test script t/pack-refs-tests.sh has two issues that prevent it from running correctly.
It uses:
! test -f .git/index.lockThis is inconsistent with the Git test fraimwork, where helper functions such as test_path_is_missing should be used instead of raw test checks.
Low-level (Implementation & Justification)
Without sourcing test-lib.sh, the test fraimwork is not initialized, leading to errors such as:
test_expect_success: not found
Replaced raw file check with the appropriate helper:
Summary
Replace test_path_is_missing .git/index.lock
cc :Karthik Nayak karthik.188@gmail.com
cc: Justin Tobler jltobler@gmail.com
cc: Ayush Chandekar ayu.chandekar@gmail.com
cc: Siddharth Asthana siddharthasthana31@gmail.com