fix: handle PR with empty body except for cc:

webstech · webstech · commit 5d5272ecf769 · 2026-03-18T16:39:35.000-07:00
If the body of the PR description is deleted and gitgitgadget adds `cc`
entries, it will add a couple of empty lines before the `cc`.  This was not
picked up and the `cc(s)` were sent as the description.  Contributors manually
adding a `cc` did not add the empty lines.

The fix is to allow the description to have no content before the empty lines.

Signed-off-by: Chris. Webster &lt;chris@webstech.net&gt;
diff --git a/lib/patch-series.ts b/lib/patch-series.ts
@@ -208,7 +208,7 @@ export class PatchSeries {
         let rangeDiff: string | undefined;
 
         // parse the footers of the pullRequestDescription
-        let match = prBody.match(/^([^]+)\n\n([^]+)$/);
+        let match = prBody.match(/^([^]*)\n\n([^]+)$/);
 
         if (!match && !prBody.match(/\n\n/)) {
             // handle PR descriptions that have no body, just footers
diff --git a/tests/patch-series.test.ts b/tests/patch-series.test.ts
@@ -496,6 +496,15 @@ Fetch-It-Via: git fetch ${repoUrl} my-series-v1
 
             expect(parsed.coverLetter).toEqual(expectedCover1);
 
+            // test with empty body and gitgitgadget added cc's
+            const cc = "Some Person <shout@out.loud>";
+            prBody = ["", "", `Cc: ${cc}`].join("\r\n");
+
+            parsed = await PatchSeries.parsePullRequest(repo.workDir, prTitle, prBody, 76, "");
+
+            expect(parsed.coverLetter.length).toEqual(prTitle.length);
+            expect(parsed.cc).toEqual([cc]);
+
             // Markdown-formatted Cc test (copy/pasted from GitHub)
             prBody = [
                 "some description",
