pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

URL: http://github.com/graphql-python/flask-graphql/pull/51

0bd78641c0a1f3e0.css" /> Support multipart requests / file uploads by rshk · Pull Request #51 · graphql-python/flask-graphql · GitHub
Skip to content

Support multipart requests / file uploads#51

Open
rshk wants to merge 2 commits intographql-python:masterfrom
rshk:support-multipart-requests
Open

Support multipart requests / file uploads#51
rshk wants to merge 2 commits intographql-python:masterfrom
rshk:support-multipart-requests

Conversation

@rshk
Copy link
Copy Markdown

@rshk rshk commented Jul 24, 2018

Requests with multipart/form-data were handled incorrectly, preventing file upload functionality from working.

I fixed GraphQLView to support file uploads according to the specification.

This is currently used in production to receive file uploads via apollo-upload-client.

Haven't really tested on Py2 or <3.6, test suite seems to be happy though.

@rshk rshk mentioned this pull request Jul 24, 2018
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-9.3%) to 84.247% when pulling 84583cf on rshk:support-multipart-requests into 4183613 on graphql-python:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-9.3%) to 84.247% when pulling 84583cf on rshk:support-multipart-requests into 4183613 on graphql-python:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 24, 2018

Coverage Status

Coverage increased (+1.07%) to 94.615% when pulling 9e69073 on rshk:support-multipart-requests into 4183613 on graphql-python:master.

@rshk rshk force-pushed the support-multipart-requests branch from 84583cf to c67fc48 Compare July 24, 2018 21:51
@rshk rshk force-pushed the support-multipart-requests branch from 5aafca9 to 52e647f Compare July 25, 2018 12:20
@Fenkiou
Copy link
Copy Markdown

Fenkiou commented Mar 18, 2019

Any update on this?

@sabard
Copy link
Copy Markdown

sabard commented Aug 2, 2019

I've been using graphene-file-upload for now. Code looks to be doing pretty much the same thing as this.

Will be nice to consolidate when this gets merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

pFad - Phonifier reborn

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.





Check this box to remove all script contents from the fetched content.



Check this box to remove all images from the fetched content.


Check this box to remove all CSS styles from the fetched content.


Check this box to keep images inefficiently compressed and original size.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy