Added description to relationships#200
Open
sedough wants to merge 1 commit intographql-python:masterfrom
Open
Conversation
jnak
reviewed
Apr 2, 2019
Collaborator
jnak
left a comment
jnak
left a comment
There was a problem hiding this comment.
Nice. Seems like a good idea. Would you mind adding simple tests for that?
graphene_sqlalchemy/converter.py
Outdated
| @@ -35,7 +35,7 @@ def dynamic_type(): | |||
| elif direction in (interfaces.ONETOMANY, interfaces.MANYTOMANY): | |||
| if _type._meta.connection: | |||
| return createConnectionField(_type._meta.connection) | |||
Collaborator
There was a problem hiding this comment.
It seems like createConnectionField could benefit from this as well
sedough
force-pushed
the
relationship-doc
branch
from
e87ef28 to
8168aaa
Compare
|
@jnak Any progress on this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generates a description for a SQLAlchemy relationship field using the "doc" attribute.