Remove transitive dependency greenlet from setup.py#424
Open
karyotakisg wants to merge 1 commit intographql-python:masterfrom
Open
Remove transitive dependency greenlet from setup.py#424karyotakisg wants to merge 1 commit intographql-python:masterfrom
karyotakisg wants to merge 1 commit intographql-python:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of our ongoing research on Python dependency management we noticed a potential improvement in your project’s dependency management.
Specifically, the transitive dependency
greenletfromSQLAlchemyis specified as a requirement in thesetup.py, when in reality it is not needed.This PR removes it from requirements.txt to let pip manage it automatically, which helps keeping the dependency list clean.
Hope this is helpful!
Best regards