Add a 'text/plain' repr to Markdown and JSON#14150
Open
mizoru wants to merge 2 commits intoipython:mainfrom
Open
Add a 'text/plain' repr to Markdown and JSON#14150mizoru wants to merge 2 commits intoipython:mainfrom
mizoru wants to merge 2 commits intoipython:mainfrom
Conversation
Carreau
reviewed
Sep 6, 2023
Comment on lines
+605
to
+607
|
|
||
| def __repr__(self): | ||
| return self.data |
Member
There was a problem hiding this comment.
Thanks for this !
Shouldn't the JSON text representation return something more like Json.dumps(self.data, indent=2) ?
Contributor
There was a problem hiding this comment.
IDK how to make that optional for jsonlines or similar; so this is fine as-is imho
Contributor
There was a problem hiding this comment.
Unless it could be __str__ instead of __repr__?
Contributor
There was a problem hiding this comment.
so that repr(Markdown('# h1')) still works, and won't display() default to Markdown.__str__ before Markdown.__repr__?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses this issue.