Hi @themavik , thank you for your review comment. I understand that this solution isn’t fully theme-independent. Would you prefer that I make it theme-aware, for example, by adjusting the colors based on whether the user is using a light or dark theme?
I also noticed that merging is currently blocked. Could you please let me know what might be causing this? I created a separate branch before opening the PR, so I’d appreciate any guidance on what I might have missed.

unfortunately this works for you, but not on all terminal themes, in some case this is worse:

Maybe update tb_highlight and tb_highlight_style to be settable as part of the theme for flexibilty

Hi @Carreau, I’ve updated the implementation to make the traceback highlight theme-dependent for the four built-in themes: Neutral, Linux, LightBG, and NoColor.

theme_highlight_map = {
    "linux": "ansiblack bg:ansiyellow",
    "neutral": "ansiblack bg:ansiyellow",
    "lightbg": "bg:ansiblue",
    "nocolor": "",
}

Would this approach be acceptable, or would you prefer a different way of wiring it into the theme system?

Thanks for the review.

You want to update class Theme in pycolorize to either:

• add a tb_highlight attribute
• or allow a Token.TbHighlight: str entry in the style dict (I think I prefer this one, but I could be convinced otherwise)

Then in

base_style = theme_table[self._theme_name].as_pygments_style()
style = stack_data.style_with_executing_node(base_style, self.tb_highlight)

you can probably do style_with_executing_node(base_style, theme_table[self._theme_name].get('tb_highlight', self.tb_highlight) or theme_table[self._theme_name].as_pygments_style()[Token.TbHighlight] or similar.

Hi @Carreau , I’ve made the requested changes based on your suggestions. I have added Token.TbHighlight to the style_extra dictionary for each theme. Please let me know if there’s anything else you’d like me to modify. I’d be happy to help. Thanks again for your feedback.

Thanks ! That might not make it to today's release, but probably for the next one.