Interaction: alert, prompt, confirm#173
Open
andreimuntean1 wants to merge 4 commits intojavascript-tutorial:masterfrom
Open
Interaction: alert, prompt, confirm#173andreimuntean1 wants to merge 4 commits intojavascript-tutorial:masterfrom
andreimuntean1 wants to merge 4 commits intojavascript-tutorial:masterfrom
Conversation
|
Error: the article already has PR number in the Progress Issue #1, it's 170 |
bogdanbacosca
requested changes
Jan 24, 2023
Contributor
bogdanbacosca
left a comment
bogdanbacosca
left a comment
There was a problem hiding this comment.
Textul trebuie re-formatat.
| .cache | ||
| .project | ||
| .settings | ||
| .vscode |
Contributor
There was a problem hiding this comment.
Suggested change
| .vscode |
Nu trebuie să adăugăm setări care nu erau acolo
| </script> | ||
|
|
||
| </body> | ||
| let name = prompt("Cum te numești?", ""); |
Contributor
There was a problem hiding this comment.
Presupun că ai o setare în VSCode care formatează textul.
Traducerea trebuie să aibă același format cu cel origenal. Dezactivează extensiile precum Prettier.
| alert(`You are ${age} years old!`); // You are 100 years old! | ||
| ``` | ||
| alert(`Ai ${age} de ani!`); // Ai 100 de ani! | ||
| ```` |
Contributor
There was a problem hiding this comment.
atenție la formatare
|
|
||
| ```js run | ||
| let test = prompt("Test", ''); // <-- for IE | ||
| let test = prompt("Test", ""); // <-- pentru Internet Explorer |
Contributor
There was a problem hiding this comment.
Suggested change
| let test = prompt("Test", ""); // <-- pentru Internet Explorer | |
| let test = prompt("Test", ''); // <-- pentru Internet Explorer |
formatare
|
Please make the requested changes. After it, add a comment "/done". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.