Skip invasive test and add one that works on Java 9+

headius · headius · commit 2465a9375fba · 2020-06-24T03:24:33.000-05:00
The skipped test will fail on Java 9+ because we are calling from
a named module into a java.base package that's not open. In order
to keep the basic spirit of the test running, I added a similar
test against the JI fixtures we load via classpath.

These APIs (JavaClass etc) are deprecaed, but we do not yet have
a clean path to replacing and removing them. Therefore we should
at least keep basic tests working.
diff --git a/spec/java_integration/fixtures/JavaFields.java b/spec/java_integration/fixtures/JavaFields.java
@@ -52,6 +52,8 @@ public class JavaFields {
     public Boolean trueObjField = Boolean.TRUE;
     public Boolean falseObjField = Boolean.FALSE;
 
+    private final int privateIntField = 1;
+
     Object field1 = this;
     Object[] aryField2 = new Object[] { this };
 
diff --git a/test/jruby/test_higher_javasupport.rb b/test/jruby/test_higher_javasupport.rb
@@ -917,7 +917,27 @@ def test_direct_package_access
     assert_equal(0, a.size)
   end
 
+  def test_open_reflected_field
+    java_fields = Java::JavaClass.for_name('java_integration.fixtures.JavaFields')
+    begin
+      java_fields.field('privateIntField')
+      fail('value field is not public!')
+    rescue NameError => e
+      assert e
+    end
+    value_field = java_fields.declared_field('privateIntField')
+    assert_equal false, value_field.static?
+    assert_equal false, value_field.public?
+    assert_equal true, value_field.final?
+    assert_equal false, value_field.accessible?
+    value_field.accessible = true
+    assert_equal 1, value_field.value( java_fields.constructor.new_instance )
+    assert_equal 'int', value_field.value_type
+  end
+
   def test_reflected_field
+    skip if JAVA_9
+
     j_integer = Java::JavaClass.for_name('java.lang.Integer')
     begin
       j_integer.field('value')
