anonymous Ruby classes should have a familiar Java class name

kares · kares · commit 84eb04f62f0b · 2016-08-31T11:30:14.000+02:00
... for easier identification of which Ruby class they represent
diff --git a/core/src/main/java/org/jruby/RubyClass.java b/core/src/main/java/org/jruby/RubyClass.java
@@ -1396,8 +1396,9 @@ public synchronized void reify(String classDumpDir, boolean useChildLoader) {
         // re-check reifiable in case another reify call has jumped in ahead of us
         if (!isReifiable()) return;
 
-        // calculate an appropriate name, using "Anonymous####" if none is present
-        final String name = getBaseName() != null ? getName() : ("AnonymousRubyClass__" + id);
+        // calculate an appropriate name, for anonymous using inspect like format e.g. "Class:0x628fad4a"
+        final String name = getBaseName() != null ? getName() :
+                ( "Class:0x" + Integer.toHexString(System.identityHashCode(this)) );
 
         final String javaName = "rubyobj." + name.replaceAll("::", ".");
         final String javaPath = "rubyobj/" + name.replaceAll("::", "/");
diff --git a/spec/java_integration/reify/become_java_spec.rb b/spec/java_integration/reify/become_java_spec.rb
@@ -188,6 +188,16 @@ def ola(*args); "OLA #{args.join(' ')}" end
     expect( j_class.newInstance.ola('Jozko') ).to eql 'OLA Jozko'
   end
 
+  it 'has a similar Java class name' do
+    ReifiedSample.become_java!
+    klass = ReifiedSample.java_class
+    expect( klass.getName ).to eql 'rubyobj.ReifiedSample'
+    klass = Class.new(ReifiedSample)
+    hexid = klass.inspect.match(/(0x[0-9a-f]+)/)[1]
+    klass = klass.become_java!
+    expect( klass.getName ).to match /^rubyobj.Class.?#{hexid}/ # rubyobj.Class:0x599f1b7
+  end
+
   describe "java fields" do
     let(:klass) { Class.new(&fields) }
     let(:fields) { proc { java_field "java.lang.String foo" } }
