Remove rogue exit(0) that shuts down JVM

headius · headius · commit e39cc9809bae · 2024-11-20T11:00:09.000-06:00
For normal JRuby use, we let the main script finish and Main.main exits. If non-daemon threads remain running, they will keep the JVM alive. However a change for CRaC support accidentally introduced a hard exit(0) that is always encountered, even if the script did not request a hard exit using `exit` or similar Ruby calls. This patch removes the hard exit(0) so that "casual" exit from the main script does not force the JVM to shut down. The runtime will still be torn down as usual, but non-daemon threads can keep the JVM alive after JRuby itself has exited. Fixes #8416
diff --git a/core/src/main/java/org/jruby/Main.java b/core/src/main/java/org/jruby/Main.java
@@ -199,8 +199,6 @@ public static void main(String[] args) {
             if (status.isExit()) {
                 System.exit(status.getStatus());
             }
-
-            System.exit(0);
         }
         catch (RaiseException ex) {
             System.exit( handleRaiseException(ex) );

Original file line number	Diff line number	Diff line change
`@@ -199,8 +199,6 @@ public static void main(String[] args) {`
`199`	`199`	`if (status.isExit()) {`
`200`	`200`	`System.exit(status.getStatus());`
`201`	`201`	`}`
`202`		`-`
`203`		`- System.exit(0);`
`204`	`202`	`}`
`205`	`203`	`catch (RaiseException ex) {`
`206`	`204`	`System.exit( handleRaiseException(ex) );`