pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

URL: http://github.com/jruby/jruby/pull/6743

com/assets/global-0bd78641c0a1f3e0.css" /> [ci] do not rely on PATH and installed mvn/ant by kares · Pull Request #6743 · jruby/jruby · GitHub
Skip to content

[ci] do not rely on PATH and installed mvn/ant#6743

Open
kares wants to merge 8 commits intojruby:masterfrom
kares:ci-refactor
Open

[ci] do not rely on PATH and installed mvn/ant#6743
kares wants to merge 8 commits intojruby:masterfrom
kares:ci-refactor

Conversation

@kares
Copy link
Copy Markdown
Member

@kares kares commented Jul 5, 2021

mostly, extracting CI bits from trying to setup ARM64 testing (which is smt I hope to follow up with)

NOTE: ant isn't still completely dropped but the mspec launcher now uses Rake's sh helper instead,
so it's "only" used from gem_installers.rake which do not execute on CI

@kares kares changed the title [ci] do not rely on PATH and installed mvn [ci] do not rely on PATH and installed mvn/ant Jul 5, 2021
@kares kares added this to the Non-Release milestone Jul 5, 2021
@kares kares requested a review from headius July 5, 2021 17:25
@kares
Copy link
Copy Markdown
Member Author

kares commented Jul 7, 2021

interesting, this seems to be causing a regression in the regression spec suite:

Failures:

  1) #4122 Stdio streams in a simple non-native JRuby instance should have sane fileno

     Failure/Error: expect(filenos[0]).to eq 0

     

     NoMethodError:

       undefined method `[]' for nil:NilClass

     # ./spec/regression/GH-4122_stdio_fileno_sanity_spec.rb:10:in `block in <main>'


Finished in 1 minute 7.31 seconds (files took 2.49 seconds to load)

407 examples, 1 failure

Failed examples:

rspec ./spec/regression/GH-4122_stdio_fileno_sanity_spec.rb:8 # #4122 Stdio streams in a simple non-native JRuby instance should have sane fileno

@headius
Copy link
Copy Markdown
Member

headius commented Jul 7, 2021

omg I would love to get ant out of the Rake targets. Great progress!

@headius
Copy link
Copy Markdown
Member

headius commented Jul 27, 2021

Looks good, but I am also confused about the failure. Seems like it is unable to launch JRuby.

@headius
Copy link
Copy Markdown
Member

headius commented Jul 27, 2021

@kares
Copy link
Copy Markdown
Member Author

kares commented Aug 9, 2021

that one last failure from Travis is confusing as I do not see the job definition 😮 for spec:ruby:fast:jit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

pFad - Phonifier reborn

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.





Check this box to remove all script contents from the fetched content.



Check this box to remove all images from the fetched content.


Check this box to remove all CSS styles from the fetched content.


Check this box to keep images inefficiently compressed and original size.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy