respond_to?(<symbol>) => true optimization#8862
Draft
headius wants to merge 9 commits intojruby:masterfrom
Draft
respond_to?(<symbol>) => true optimization#8862headius wants to merge 9 commits intojruby:masterfrom
headius wants to merge 9 commits intojruby:masterfrom
Conversation
Member
Author
|
This could be expanded to make false results also constant by additionally checking if |
headius
force-pushed
the
respond_to_optz
branch
2 times, most recently
from
939f4c1 to
d368cf1
Compare
Member
Author
|
This needs some refactoring to work properly. I hack one fix in and break something else. On pause for the moment until I can get some time to rework indy call sites for more composability. |
headius
force-pushed
the
respond_to_optz
branch
from
d368cf1 to
66aaa74
Compare
This optimizes the common case of respond_to? with a literal symbol. When the method is "naturally" respond_to? => true then that result can be cached behind the usual guards. This makes the success path essentially free. The logic here has a lot of copied behavior from elsewhere and utilizes some now-static methods from InvokeSite, so it could be refactored along with the rest of indy logic to be much simpler. There's a lot of duplicated code here from other call site forms, demonstrating the need for a refactor of all indy binding logic.
We can cache a true result only if respond_to? is the built-in version and it would return true. We can cache a false result if respond_to? is built-in and returns false and respond_to_missing? is not define or both are undefined. All other cases must dispatch through slow-path logic (normal dynamic invocation of respond_to?).
headius
force-pushed
the
respond_to_optz
branch
from
f5a2694 to
b98fd6f
Compare
headius
force-pushed
the
respond_to_optz
branch
from
b98fd6f to
da95b88
Compare
headius
force-pushed
the
respond_to_optz
branch
from
2dd5c41 to
1f304bd
Compare
Member
Author
|
Back to draft with recent refactoring and some missing safety guards like preventing it from binding every class it ever sees: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This optimizes the common case of respond_to? with a literal symbol. When the method is "naturally" respond_to? => true then that result can be cached behind the usual guards. This makes the success path essentially free.
The logic here has a lot of copied behavior from elsewhere and utilizes some now-static methods from InvokeSite, so it could be refactored along with the rest of indy logic to be much simpler.