Expand Signature to represent all metadata#9220
Draft
headius wants to merge 2 commits intojruby:masterfrom
Draft
Expand Signature to represent all metadata#9220headius wants to merge 2 commits intojruby:masterfrom
headius wants to merge 2 commits intojruby:masterfrom
Conversation
headius
force-pushed
the
complete_signature
branch
from
a8637e5 to
9cf96e9
Compare
This expands signature to hold an array of KeywordArgument objects that describe the keyword arguments for this method signature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have used Signature for years to represent all forms of positional arguments, but for keyword arguments it only tracks how many there are, how many are required, and whether there's a kwrest argument. This is insufficient to use Signature as a comprehensive representation of all possible signature forms, needed for upcoming improvements to invocation.
This PR will attempt to expand Signature to support the full range of possible Ruby caller and callee signatures.