Properly complete Fiber#raise transfer#9356
Merged
headius merged 1 commit intojruby:jruby-10.0from Apr 1, 2026
Merged
Conversation
Fiber#raise still returns a request from the target fiber, but the finally block intended to finish the transfer would only do so if a exception was immediately raised during the transfer. As a result the fiber was left in a "resumed" state and further resumes would error. These state changes need to be re-audited and cleaned up but at least in this case it's clear that the completion of the raise request should not leave the fiber stuck in resume mode. Fixes jruby#9297
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fiber#raise still returns a request from the target fiber, but the finally block intended to finish the transfer would only do so if a exception was immediately raised during the transfer. As a result the fiber was left in a "resumed" state and further resumes would error.
These state changes need to be re-audited and cleaned up but at least in this case it's clear that the completion of the raise request should not leave the fiber stuck in resume mode.
Fixes #9297