pFad - Phone/Frame/Anonymizer/Declutterfier! Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

URL: http://github.com/jruby/jruby-openssl/pull/336

/global-0bd78641c0a1f3e0.css" /> Fix asn1data - objectid by HoneyryderChuck · Pull Request #336 · jruby/jruby-openssl · GitHub
Skip to content

Fix asn1data - objectid#336

Open
HoneyryderChuck wants to merge 3 commits intojruby:masterfrom
HoneyryderChuck:fix-asn1data-2
Open

Fix asn1data - objectid#336
HoneyryderChuck wants to merge 3 commits intojruby:masterfrom
HoneyryderChuck:fix-asn1data-2

Conversation

@HoneyryderChuck
Copy link
Copy Markdown
Contributor

@HoneyryderChuck HoneyryderChuck commented Jul 30, 2025

add ruby-openssl objectid tests + fixing the discrepancies.

@HoneyryderChuck
fixed logic around error parsing oid
4daed8e 
it's supposed to raise on der encoding (not initialization), and it's supposed to be an ASN1Error (not TypeError) exception
@HoneyryderChuck
fixed comparison of ObjectId
f977be2 
same behaviour as upstream now, it compares the translated oid strings
@HoneyryderChuck
importing objectid tests from upstream as is
5879e37 
the existing batch wasn't synched; commented the test around registering of nids
@kares
Copy link
Copy Markdown
Member

kares commented Oct 21, 2025

there seems to be a regression with the existing tests, reported by the CI:

 Failure: test_subject_alt_name_sign_to_pem(TestX509Extension)
/home/runner/work/jruby-openssl/jruby-openssl/src/test/ruby/x509/test_x509ext.rb:199:in `test_subject_alt_name_sign_to_pem'
     196:     csr = OpenSSL::X509::Request.new pem = csr.to_pem
     197:     assert_equal 2, csr.attributes.length
     198:     ext_set = csr.attributes.first.value ; seq = ext_set.first.value
  => 199:     assert_equal 'subjectAltName', seq.first.value.first.value
     200:     dns = seq.first.value.last.value
     201:     assert dns =~ /test.example.com.*?test2.example.com.*?example.com.*?www.example.com/
     202:   end
org/jruby/RubyKernel.java:1189:in `catch'
org/jruby/RubyKernel.java:1184:in `catch'
org/jruby/RubyArray.java:1820:in `each'
org/jruby/RubyArray.java:1820:in `each'
org/jruby/RubyKernel.java:1189:in `catch'
org/jruby/RubyKernel.java:1184:in `catch'
<"subjectAltName">(US-ASCII) expected but was
<"2.5.29.17">(UTF-8)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

work-wanted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HoneyryderChuck @kares
pFad - Phonifier reborn

Pfad - The Proxy pFad © 2024 Your Company Name. All rights reserved.




Check this box to remove all script contents from the fetched content.



Check this box to remove all images from the fetched content.


Check this box to remove all CSS styles from the fetched content.


Check this box to keep images inefficiently compressed and original size.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy