Fixing install of headers when using an experimental feature#7202
Open
Honeybunch wants to merge 1 commit intolibgit2:mainfrom
Open
Fixing install of headers when using an experimental feature#7202Honeybunch wants to merge 1 commit intolibgit2:mainfrom
Honeybunch wants to merge 1 commit intolibgit2:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to use the experimental sha256 feature via vcpkg I ran into this issue: #7199
So here I've made a small modification to the cmake script so that all header files in the include directory are updated to point at git2-experimental/. The target's install interface had to be modified so that it uses the unmodified include/ headers from the source tree to build but points the installed target to the modified, installed headers.
I verified that this worked by creating a custom vcpkg port and overriding our usage of libgit2 to point to this change. It built and installed without incident and our tool can now properly interact with sha256 repos as expected.