mathtext: Fix type inconsistency with fontmaps#31437
Merged
tacaswell merged 2 commits intomatplotlib:mainfrom Apr 2, 2026
Merged
mathtext: Fix type inconsistency with fontmaps#31437tacaswell merged 2 commits intomatplotlib:mainfrom
tacaswell merged 2 commits intomatplotlib:mainfrom
Conversation
Previously, some fontmaps used integer keys for some special font entries, but there's no reason why they can't also be strings, which should reduce the type inconsistency across the whole file. Also, fix a couple of other type errors with strict mypy. Fixes matplotlib#31433
timhoffm
approved these changes
Apr 2, 2026
Member
Author
|
Looks like stubtest also required a fixup, as it doesn't run if it fails on mypy before it. |
tacaswell
approved these changes
Apr 2, 2026
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Previously, some fontmaps used integer keys for some special font entries, but there's no reason why they can't also be strings, which should reduce the type inconsistency across the whole file.
Also, fix a couple of other type errors with strict mypy.
Fixes #31433
AI Disclosure
None
PR checklist