fix(streamable-http): reduce stateless termination log noise#2357
Open
BlocksecPHD wants to merge 3 commits intomodelcontextprotocol:mainfrom
Open
fix(streamable-http): reduce stateless termination log noise#2357BlocksecPHD wants to merge 3 commits intomodelcontextprotocol:mainfrom
BlocksecPHD wants to merge 3 commits intomodelcontextprotocol:mainfrom
Conversation
|
@claude review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adjusts termination logging in
StreamableHTTPServerTransportfor stateless mode.INFOlog for stateful session termination (session id exists)DEBUGlog for stateless transport cleanup (mcp_session_id is None)This addresses confusion reported in #2329 where users interpret
Terminating session: Noneas an error condition.Changes
src/mcp/server/streamable_http.pyterminate()tests/server/test_streamable_http_manager.pyTerminating session: Nonemessage is not emittedValidation
Ran targeted tests locally:
python -m pytest tests/server/test_streamable_http_manager.py \ -k 'stateless_requests_memory_cleanup or stateless_termination_logs_debug_not_info'Result:
2 passed